IGNITE-23632 Support force deactivation flag in thin client #11647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nizhikov
reviewed
Nov 13, 2024
| * @throws ClientException If change state operation failed. | ||
| */ | ||
| @IgniteExperimental | ||
| public void state(ClusterState newState, boolean forceDeactivation) throws ClientException; |
There was a problem hiding this comment.
Corresponding method for a node implemented in private API - IgniteClusterEx.
Can we implement this into private thin client methods, also?
nizhikov
reviewed
Nov 13, 2024
| if (protocolCtx.isFeatureSupported(ProtocolBitmaskFeature.FORCE_DEACTIVATION_FLAG)) { | ||
| req.out().writeBoolean(forceDeactivation); | ||
| } | ||
| else if (forceDeactivation) { |
There was a problem hiding this comment.
This will break change state from new client to old servers:
state(ClusterState newState) always pass true and old server not support forceDeactivation.
So, any change of cluster state from thin client will throw ClientFeatureNotSupportedByServerException.
There was a problem hiding this comment.
Fixed, thank you.
nizhikov
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.